[Openswan dev] Re: PATCH: fix oops during KLIPS unloading

Michael Richardson mcr at sandelman.ottawa.on.ca
Thu Feb 16 15:54:20 CET 2006


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1


>>>>> "D" == D Hugh Redelmeier <hugh at mimosa.com> writes:
    D> Read what I said more carefully: it is the test that will not be
    D> tested properly unless you go out of your way to revert the fix.

  You have to confirm that, without the fix, the test case actually
*fails*

  That's why it just frequently isn't interesting to me to read a 10MB
log file of some situation that I can't repeat trivially. 
  The *hard* work is turning that into a repeatable situation. 
  Sometimes that calls for introducing an impairment into another part
of the code.  It's also why I dislike threads --- they introduce an
element of non-determinism which makes repeating things hard.
  (It's also why kernel code is so hard -- it's always threaded, even in
non-thread-aware kernels running on UP. there is always an interrupt thread)

- -- 
]       ON HUMILITY: to err is human. To moo, bovine.           |  firewalls  [
]   Michael Richardson,    Xelerance Corporation, Ottawa, ON    |net architect[
] mcr at xelerance.com      http://www.sandelman.ottawa.on.ca/mcr/ |device driver[
] panic("Just another Debian GNU/Linux using, kernel hacking, security guy"); [
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
Comment: Finger me for keys

iQEVAwUBQ/Tmc4CLcPvd0N1lAQLfYQf/eOVehDJLpg6yFFM8b5k9ipSoDPUt8DLK
2EwpGqoMF3/ES688/lcZ1dhLa2rPn+TDBYfIR7HGevggiRmhoqfn+Gigzixs8+A3
BEuHYn/GO9XlWfxvV4YDnGnR2XQewzbq0FHZNs2TJwGvu6BFNhAo4G4WKuqvHAVM
O1gVoEMZJO4Xd6gqsWcfjeNY3EycP+C6RMxl+mvs6Ux18AZXEBbMywKJZb4iYEbT
tQkLloVNMrYdYO7Ok6OfNv4UKY3GYiodpOVIVokVh2IR+56z2BUYuVea3mMW+eq5
YJF+ksg7bThdSjbbrlK03j72Nex/y73a76D2Xw9USAyZg6npW30sSQ==
=tERu
-----END PGP SIGNATURE-----


More information about the Dev mailing list