[Openswan dev]

[Michael Richardson]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1


>>>>> "Ankit" == Ankit Desai <ankit at elitecore.com> writes:
    Ankit> yes as i said i just tried to remove the recursion in
    Ankit> code. Other than that as i understand the two functions
    Ankit> ensures that the task is performed uninterruptible.

    >> In my copy of the code, I do not agree that pfkey_remove_socket()
    >> is called with a lock.

    Ankit> pfkey_release takes lock "write_lock_bh(&pfkey_sock_lock)"

My copy doesn't do that.

    Ankit> and then calls "pfkey_destroy_socket(sk)" which in turn calls
    Ankit> " pfkey_remove_socket(sk)", that is what i meant by
    Ankit> pfkey_remove_socket is called after taking lock.

So, you are saying that we have a call graph that looks like:

   pfkey_create()
       pfkey_insert_socket()
	   pfkey_sock_list_grab()

     Ankit> so the best i could think was to implement the lock before
    Ankit> pfkey_insert_socket and remove the locking unlocking from
    Ankit> of_grab() and _ungrab().  Best would be to remove locking
    Ankit> before remove_socket is called but i am very much a newbie to
    Ankit> understand the complexity and implications of that.

  Please don't under-estimate yourself.
  Your analysis is very good so far!  New eyes are often better than
eyes that read what they expect.

  You need to probably move the call to pfkey_sock_list_grab() out a bit
in the call tree.

  I have placed my copy of pfkey_v2.c at 
      http://www.sandelman.ca/tmp/pfkey_v2.c

  Please try using git to get a copy of our #public.
  I don't think that my tree has any changes relative to that.

- -- 
]       ON HUMILITY: to err is human. To moo, bovine.           |  firewalls  [
]   Michael Richardson,    Xelerance Corporation, Ottawa, ON    |net architect[
] mcr at xelerance.com      http://www.sandelman.ottawa.on.ca/mcr/ |device driver[
] panic("Just another Debian GNU/Linux using, kernel hacking, security guy"); [



-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
Comment: Finger me for keys

iQEVAwUBQ/SabYCLcPvd0N1lAQIzhgf9EfUgWgc1UUpjvWeOFIrObYGy0Z+BaLTs
maKTRBzivQMyXIex3xvL/fPMGpPo0N8bju6xm4YaJaZMz19UTd8nRmOT5fIOSOA0
HATu51At0lSFLZgqAJT2cK7/ZMydHfLGVzDSjux0CirQSEhYc4/EwdaOYqrofICI
f+ovzuvdacWhhjE2mzrnGrQM6i7kzwkMH4GgbnIL+jl5Fiy738uDxKYOgD9yrncg
tFg+EIB/W9rPnfrVcOs3Xa1LgJbZVVRdf+Enz8jwSpy7ME1I2BR2Qxpbrivt27NK
BJxaltstXhsctq7WT7AHiKsPZLRTQHv62x81nyA7MoEUX6V/514M3A==
=562O
-----END PGP SIGNATURE-----