[Openswan dev] Fwd: Re: fix for sha2_truncbug-option in whack

[Andrey Alexandrenko]

-------- Original Message --------
Subject: 	Re: [Openswan dev] fix for sha2_truncbug-option in whack
Date: 	Thu, 20 Sep 2012 12:29:53 -0400 (EDT)
From: 	Paul Wouters <paul at nohats.ca>
To: 	Andrey Alexandrenko <aalexandrenko at telco-tech.de>



On Thu, 20 Sep 2012, Andrey Alexandrenko wrote:

> whack in 3.6.38 do not accept 'sha2_truncbug' with arguments like '--sha2_truncbug=yes'. My patch
> fixes that.

It should not accept arguments. It's on when passed as flag.

> PS. '--sha2_truncbug' (without arguments) causes segmentation fault in whack.

That's odd, do you have a gdb backtrace?

Paul
>

I don't have a gdb backtrace, but I guess it crashes on strcmp with NULL:

  	case CD_SHA2_TRUNCBUG: /* --sha2_truncbug */
	    if ( strcmp(optarg, "yes" ) == 0) {
		msg.sha2_truncbug = SHA2_TRUNCBUG_YES;
	    }
	    else {
		msg.sha2_truncbug = SHA2_TRUNCBUG_NO;
	    }
		continue;


Andrey



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openswan.org/pipermail/dev/attachments/20120924/17072094/attachment.html>