<html>
<head>
<meta http-equiv="content-type" content="text/html; charset=ISO-8859-1">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<br>
<div class="moz-forward-container"><br>
<br>
-------- Original Message --------
<table class="moz-email-headers-table" border="0" cellpadding="0"
cellspacing="0">
<tbody>
<tr>
<th align="RIGHT" nowrap="nowrap" valign="BASELINE">Subject:
</th>
<td>Re: [Openswan dev] fix for sha2_truncbug-option in whack</td>
</tr>
<tr>
<th align="RIGHT" nowrap="nowrap" valign="BASELINE">Date: </th>
<td>Thu, 20 Sep 2012 12:29:53 -0400 (EDT)</td>
</tr>
<tr>
<th align="RIGHT" nowrap="nowrap" valign="BASELINE">From: </th>
<td>Paul Wouters <a class="moz-txt-link-rfc2396E" href="mailto:paul@nohats.ca"><paul@nohats.ca></a></td>
</tr>
<tr>
<th align="RIGHT" nowrap="nowrap" valign="BASELINE">To: </th>
<td>Andrey Alexandrenko <a class="moz-txt-link-rfc2396E" href="mailto:aalexandrenko@telco-tech.de"><aalexandrenko@telco-tech.de></a></td>
</tr>
</tbody>
</table>
<br>
<br>
<pre>On Thu, 20 Sep 2012, Andrey Alexandrenko wrote:
> whack in 3.6.38 do not accept 'sha2_truncbug' with arguments like '--sha2_truncbug=yes'. My patch
> fixes that.
It should not accept arguments. It's on when passed as flag.
> PS. '--sha2_truncbug' (without arguments) causes segmentation fault in whack.
That's odd, do you have a gdb backtrace?
Paul
>
I don't have a gdb backtrace, but I guess it crashes on strcmp with NULL:
case CD_SHA2_TRUNCBUG: /* --sha2_truncbug */
if ( strcmp(optarg, "yes" ) == 0) {
msg.sha2_truncbug = SHA2_TRUNCBUG_YES;
}
else {
msg.sha2_truncbug = SHA2_TRUNCBUG_NO;
}
continue;
</pre>
<br>
<pre>Andrey</pre>
<br>
</div>
<br>
</body>
</html>