[Openswan dev] nss/nspr4 warning and PLUTO_SENDS_VENDORID vs HAVE_LIBNSS

[Elio Maldonado Batiz]

On Sun, Jan 3, 2010 at 10:25 AM, Paul Wouters <paul at xelerance.com> wrote:

> On Sat, 2 Jan 2010, Elio Maldonado Batiz wrote:
>
>  Paul, Avesh,
>>
>> Regarding the compile error I had the same problem and know the cause,
>> see below
>>
>
>  The problem is with the NSPR header not with openswan.
>> Openswan uses the -Wstrict-prototypes flag (and -Werror) but the header
>> faulty.
>>
>> In prlink.h the offending lines are line 52
>>     void (*fp)();                     -----------------> should use
>> (void)
>> and line 221
>> typedef void (*PRFuncPtr)(); -----------------> should use (void)
>>
>> In the meantime the attached works around it by patch relaxing prototype
>> enforcement in the makefiles for rsasignkey and shhowhostkey.
>>
>
> Thanks. I've merged in your patch, and we'll remove it again once nspr
> is fixed.
>
>
>  I'll submit this work-around for fedora openswan
>> and log a bug and send a patch for nspr.
>>
>
> If you have a url/bug number for us for the nspr, please let us know so
> we can reference it.
>

I searched and someone already filed a similar bug regarding strict
prototypes
https://bugzilla.mozilla.org/show_bug.cgi?id=410677
There is a long discussion. Unfortunately, it won't be fixed for fear of
breaking existing code.

Elio


> Thanks
>
> Paul
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.openswan.org/pipermail/dev/attachments/20100103/29224b29/attachment.html