[Openswan dev] Re: PATCH: fix oops during KLIPS unloading

[Paul Wouters]

On Fri, 10 Feb 2006, Michael Richardson wrote:

>     D> | -               } while(it > proc_items);
>     D> | +               } while(it >= proc_items);
>     D> |         }
>     D> |
>     D> | <---snip--->
>
> Your patch seems well founded.
> To prove it, could someone check that without this patch, on a 2.4
> system /proc/net/ipsec/klipsdebug should fail to be removed when you
> unload the module. Accessing the file should cause a fault.

On 2.4 we never had this crasher. Perhaps kernel module cleanup fixed
this? On 2.6 this patch fixes module unload.
On 2.4, the issue we had with module unloading was the refcount issue.
Another patch by Matthias fixed that issue for us.

So at this point, the only klips bug that we have left is the SMP crasher.

> On a 2.6 system, module unloads are just not supported at present.

But they work fine now.

So execsum:

- without patch 2.4 kernel module unloads fine
- without patch 2.6 kernel module crashes
- with patch 2.4 kernel module unloads fine
- with patch 2.6 kernel module unloads fine

The bug item is left open until a testcase has been written for this issue.

Paul