[Openswan dev] Re: PATCH: fix oops during KLIPS unloading

[Michael Richardson]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1


    D> | Here is a patch that resolved my problem...
    D> | 
    D> | <---snip--->
    D> | 
    D> | --- ipsec.c.org Fri Feb 10 16:00:46 2006
    D> | +++ ipsec_proc.c        Fri Feb 10 14:10:42 2006
    D> | @@ -988,7 +988,7 @@
    D> |                 do {
    D> |                         remove_proc_entry(it->name, *it->parent);
    D> |                         it--;
    D> | -               } while(it > proc_items);
    D> | +               } while(it >= proc_items);
    D> |         }
    D> | 
    D> | <---snip--->

Your patch seems well founded.
To prove it, could someone check that without this patch, on a 2.4
system /proc/net/ipsec/klipsdebug should fail to be removed when you
unload the module. Accessing the file should cause a fault.

On a 2.6 system, module unloads are just not supported at present.

- -- 
]       ON HUMILITY: to err is human. To moo, bovine.           |  firewalls  [
]   Michael Richardson,    Xelerance Corporation, Ottawa, ON    |net architect[
] mcr at xelerance.com      http://www.sandelman.ottawa.on.ca/mcr/ |device driver[
] panic("Just another Debian GNU/Linux using, kernel hacking, security guy"); [

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
Comment: Finger me for keys

iQEVAwUBQ+1D7ICLcPvd0N1lAQIF1AgAqjB6esR9ilyRFMfCxz2S06zxKFUJQDfI
c8k30s3O4dzqTes7pSzUDN+dvwTcoQDnDS2Ejr6N42ZeF7CW8Fn6oEeVSO7yTRJr
guMcZwLo6/qkKyopaT7lL7JW2RV7sybmBVAuB8+zTB99v93UBuvKJyDtRqUHcawx
ZrkV/BqS1FoMDP8wU3r4Urid0dxmGVPAqKK0MrLFx1H9oye8zkj9ORmwx95MSYIz
fWMgPGUwZ2E3lp5/xCCxW9eJinYpSJ7qWCz6Gnm59hl7Kz72J4+pFucpGZxsoc6Z
zRzSdPmf39vQ6nqWLOWlfovUSWl0vZJ21O8n6HuiL9MI8WXwBqAc5g==
=eNyo
-----END PGP SIGNATURE-----