[Openswan Users] roadwarrior over pppoe

[Paul Wouters]

On Wed, 29 Aug 2007, Paulo F. Sedrez wrote:

> I am going to this code right now, and - besides the skb and ocf stuff -
> it has a lot of interesting things - some corrections, optimizations and
> extensive logging included.

CC: me on any patch you write please.

> I will try to make a patch for it in the next few days, but I will left
> out most of the code addition from ocf - I will focus in 2.6.22
> compatibility. I don't known if the other improvements should go in
> 2.4.x version, if there is a 2.5.x to be released really soon. If there
> is not, I strong suggest David to submit the improvements that could
> into the 2.4.x branch.

Remember, the OCF code has been merged into 3.x. We will not add OCF
code in 2.5.x or 2.6.x.

> There is one, in particular, that came to my attention, since it looks
> like a bug in one of the implementations of pluto: in the file
> programs/pluto/kernel.c, line 1289 and next of stock 2.4.9:
>
>         orphaned_holds = p->next;
>         pfree(orphaned_holds);
>
> David's patch:
>
>         orphaned_holds = p->next;
>         pfree(p);

Michael? Is this a bug in 2.4.x? I see the same code in 3.x's kernel_pfkey.c

Paul


> I think David's is right, and the stock 2.4.9 shall sometime eat
> resources or crash.
>
> (BTW, David, what is LEDMAN?)
>
>

-- 
Building and integrating Virtual Private Networks with Openswan:
http://www.amazon.com/gp/product/1904811256/104-3099591-2946327?n=283155