[Openswan dev] openswan-2.6.34rc4 broken for on-demand tunneling

Paul Wouters paul at xelerance.com
Mon Jun 6 23:02:02 EDT 2011


On Mon, 6 Jun 2011, D. Hugh Redelmeier wrote:

> | From: David McCullough <david_mccullough at mcafee.com>
> 
> | -    memcpy(NLMSG_DATA(n), &ac1, sizeof(struct xfrm_user_acquire));
> | +    memcpy(&ac1, NLMSG_DATA(n), sizeof(struct xfrm_user_acquire));
> 
> | -    memcpy(NLMSG_DATA(n), &up1, sizeof(up1));
> | +    memcpy(&up1, NLMSG_DATA(n), sizeof(up1));
> 
> Baseless speculation from the peanut gallery:
> 
> Were any other memcpy calls checked in by the same author?  Are they
> backwards too?

I double checked, but those were the only memcpy changes.

Paul


More information about the Dev mailing list