[Openswan dev] /etc/init.d/setup gets installed again

[Harald Jenny]

On Wed, Oct 06, 2010 at 04:49:09PM +1000, David McCullough wrote:
> 
> Jivin Harald Jenny lays it down ...
> > On Wed, Oct 06, 2010 at 02:26:17PM +1000, David McCullough wrote:
> > > 
> > > Jivin Paul Wouters lays it down ...
> > > > On Wed, 6 Oct 2010, David McCullough wrote:
> > > > 
> > > > >> The problem was you broke "ipsec setup restart" :)
> > > > >
> > > > > I did ?  Was this the IPSEC_CONFS/hard coded paths changes ?
> > > > 
> > > > No, the not installing "setup" caused that. Which arguably needs a
> > > > different solution. Try "ipsec setup anything" after using "your"
> > > > method of not double installing :)
> > > 
> > > Ah,  ok.
> > > 
> > > I just built and installed it here with NOINSTALL=true and some extra
> > > dependancies to match Makefile.program and all looked good.
> > > 
> > > After seeing your comment I have tried "ipsec steup stop/start/restart"
> > > without any problems using netkey and klips.  Anything in particular I need
> > > to have configured ?  I am using a single tunnel in my ipsec.conf,  not
> > > fancy includes etc.
> > > 
> > > This is on an up-to-date Ubuntu 10.04 and openswan-git HEAD.  I did the
> > > "make install" over an older openswan-2.6.25 source built version.
> > 
> > :-) you don't really like debs?
> 
> I love debs[1], but when I am working on the source and making patches etc
> it's just easier.

Yeah ok that's understandable...

> 
> I still can't figure out what the problem was with my original change
> so any pointers as to why I'm a goose would be appreciated :-)

Hmmm to me it seems we should really focus on a new init scheme...

> 
> Paul, did it break the .deb package management/creation or the
> installation/generation of setup itself ?  It seems to be working for me
> so I must be doing something different,  just not sure what.  I am not
> making .deb's though.

Guess the issue is two-folded: Your change made the ipsec setup fail which got
corrected by Tuomi by installing setup in /etc/init.d again - which in turn
Debian does not like as both scripts are the same...

> 
> I do know why Tuomo's change caused you problems, just not sure what the
> problem was before that :-)

Tuomi's change made the setup get installed twice in /etc/init.d, once as setup
and once as ipsec and that made Debian init setup unhappy - your change did
break ipsec setup as far as I understand?

> 
> Thanks,
> Davidm

Kind regards
Harald

> 
> [1]: I work in embedded land (ie,  real embedded,  not headless PC's).
>      There are no deb's in most of my world,  there is no package
>      management, just source and a firmware image ;-)  So everything I do
>      is affected by that even if unintentionally.
> 
> > > The patch I am running with is attached,  but I don't think it is
> > > functionally different to the old one that failed for you,  but I might be
> > > missing the obvious.
> > > 
> > > Cheers,
> > > Davidm
> > > 
> > > -- 
> > > David McCullough,      david_mccullough at mcafee.com,  Ph:+61 734352815
> > > McAfee - SnapGear      http://www.mcafee.com         http://www.uCdot.org
> > 
> > > diff --git a/programs/setup/Makefile b/programs/setup/Makefile
> > > index bc9ed09..1a99c25 100644
> > > --- a/programs/setup/Makefile
> > > +++ b/programs/setup/Makefile
> > > @@ -20,6 +20,7 @@ include ${OPENSWANSRCDIR}/Makefile.inc
> > >  # not as /etc/rc.d/init.d/setup.
> > >  PROGRAMDIR=$(RCDIR)
> > >  PROGRAM=setup
> > > +NOINSTALL=true
> > >  EXTRA8MAN=setup.8
> > >  
> > >  include ${srcdir}../Makefile.program
> > > @@ -29,7 +30,8 @@ include ${srcdir}../Makefile.program
> > >  # into the $BINDIR.
> > >  #
> > >  # the priorities match those in setup's chkconfig line
> > > -doinstall:: setup
> > > +doinstall:: $(PROGRAM) $(CONFFILES) $(EXTRA8MAN) $(EXTRA5MAN) $(EXTRA5PROC) $(LIBFILES) $(CONFDFILES)
> > > +	# remove any old vendor file installed previously
> > >  	@rm -f $(BINDIR)/setup
> > >  	@$(INSTALL) $(INSTBINFLAGS) setup $(RCDIR)/ipsec
> > >  	@ln -s $(FINALRCDIR)/ipsec $(BINDIR)/setup
> > 
> > 
> > 
> 
> -- 
> David McCullough,      david_mccullough at mcafee.com,  Ph:+61 734352815
> McAfee - SnapGear      http://www.mcafee.com         http://www.uCdot.org