[Openswan dev] [Openswan Users] Possible bug? (fwd)

[Avesh Agarwal]

On 03/17/2010 01:53 PM, Paul Wouters wrote:
>
> ---------- Forwarded message ----------
> Date: Wed, 17 Mar 2010 15:53:27 +0100
> From: Hansjörg Pfister<hp at collax.com>
> To: users at openswan.org
> Subject: [Openswan Users] Possible bug?
>
>
> Hi,
>
> may be there's a bug in pluto:
>
> In ikev1_quick.c (2.6.24) you'll find the following at line 1972:
>
>   	 if (st->st_pfs_group != NULL) {
>   		e = build_ke(&qke->qke_pcrc, st, st->st_pfs_group, ci);
>   	    } else {
>   		e = build_nonce(&qke->qke_pcrc, st, ci);
>   	    }
>
>   	    passert(st->st_connection != NULL);<- this condition may be
> sometimes true because:
>    

I am wondering why this could be a bug?  As I understand, it will only 
fail if crypto computation takes lot of time, and the passert is exactly 
to catch that situation, so in general that should not happen. I hope I 
am not doing any misinterpretation here.

Thanks and Regards
Avesh

> in build_nonce there is at line 248:
>
> event_schedule(EVENT_CRYPTO_FAILED, EVENT_CRYPTO_FAILED_DELAY, st);
>
> this event will delete st_connection!
> Same in build_ke!
>
> Regards,
>
> Hansjoerg
> _______________________________________________
> Users at openswan.org
> http://lists.openswan.org/mailman/listinfo/users
> Building and Integrating Virtual Private Networks with Openswan:
> http://www.amazon.com/gp/product/1904811256/104-3099591-2946327?n=283155
> _______________________________________________
> Dev mailing list
> Dev at openswan.org
> http://lists.openswan.org/mailman/listinfo/dev
>