[Openswan dev] Fix for off-by-one bug in id.c

Michael H. Warfield mhw at WittsEnd.com
Thu Mar 11 23:47:46 EST 2010

Hey all,

I've mentioned this one in a couple of message on-list and in private
E-Mail to Paul.  There's an off-by-one bug in id.c impacting the
leftid=@[foo] notation (key = foo key_id_type = KEY_ID) with is rather
obscure to begin with.  leftid=@[foo works properly but leftid=@[foo] is
suppose to discard the trailing ']' and is not because the check is off
one character.  The attached patch fixes that...

Please apply.  We need it for some classes of Cisco ASA devices.

Some of that syntax should be documented in the man pages but me and XML
get along like garlic and vampires.  Sorry...

Michael H. Warfield (AI4NB) | (770) 985-6132 |  mhw at WittsEnd.com
   /\/\|=mhw=|\/\/          | (678) 463-0932 |  http://www.wittsend.com/mhw/
   NIC whois: MHW9          | An optimist believes we live in the best of all
 PGP Key: 0x674627FF        | possible worlds.  A pessimist is sure of it!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: openswan-2.6.24-id-one-off.diff
Type: text/x-patch
Size: 747 bytes
Desc: not available
Url : http://lists.openswan.org/pipermail/dev/attachments/20100311/671fd622/attachment-0002.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 482 bytes
Desc: This is a digitally signed message part
Url : http://lists.openswan.org/pipermail/dev/attachments/20100311/671fd622/attachment-0003.bin 

More information about the Dev mailing list