[Openswan dev] Assertion failed at packet.c:1672
paul at xelerance.com
Sat Feb 27 13:48:52 EST 2010
On Fri, 26 Feb 2010, D. Hugh Redelmeier wrote:
> | Well COOKIE_SIZE is 8 (found it in ietf_constants.h) so
> | NOFFSETOF_isa_np should be 16.
> Right. I just assumed that would be fixed at the same time that may
> buggy NSIZEOF_isakmp_hdr was fixed. (Thanks for that fix too.)
Fixed in git now.
> | So now I changed the assert to:
> | passert(pl[NOFFSETOF_isa_np] == ISAKMP_NEXT_NONE ||
> | pl[NOFFSETOF_isa_np] == ISAKMP_NEXT_HASH);
> | That seems to work. Well, at least it dodges the assert. If it is
> | correct is another question ;-)
> We backed off the version of that assertion in the loop. You have
> demonstrated it needs fixing here too.
This passert() is not in a loop and was still there. I've updated it as well.
Thanks for the patches Albert!
More information about the Dev