[Openswan dev] LEAK_DETECTIVE hits passert()

[D. Hugh Redelmeier]

| From: Paul Wouters <paul at xelerance.com>

| On Tue, 30 Nov 2010, Paul Wouters wrote:
| 
| With -lefence, I seem to be getting core dumps quickly. They all look like
| this:
| 
| Core was generated by `/usr/local/libexec/ipsec/pluto --nofork --secretsfile
| /etc/ipsec.secrets --ipse'.
| Program terminated with signal 11, Segmentation fault.
| #0  openswan_DBG_dump (label=0x80f3911 "     obj: ", p=0xb7e3dff8, len=8)
|     at /root/openswan-2.6.32rc2/programs/pluto/log.c:779
| 779			*bp++ = hexdig[(*cp >> 4) & 0xF];
| (gdb) bt
| #0  openswan_DBG_dump (label=0x80f3911 "     obj: ", p=0xb7e3dff8, len=8)
|     at /root/openswan-2.6.32rc2/programs/pluto/log.c:779
| #1  0x08066ac2 in process_packet_tail (mdp=0x8124c40)
|     at /root/openswan-2.6.32rc2/programs/pluto/ikev1.c:1638

The bug was here.

                DBG(DBG_PARSING, DBG_dump("     obj: ", pd->pbs.cur, pbs_room(&pd->pbs)));
should be
                DBG(DBG_PARSING, DBG_dump("     obj: ", pd->pbs.cur, pbs_left(&pd->pbs)));