[Openswan dev] Error building klips-ipv6 (missing include?)

[Ruben Laban]

Hi David,

On Thursday 26 August 2010 at 03:06 (CET), David McCullough wrote:
> Yep,  I am byteswapping a field twice,  try this patch.  I don't see it
> because my klips host id big endian :-)

This seems to fix the cosmetic issue with tcpdump just fine. I did notice 
another (probably) cosmetic issue with tcpdump though:

west# ping6 2a02:bd0:abcd:1::20 -I 2a02:bd0:abcd:4::10 -c 1 -p deadbeef
PATTERN: 0xdeadbeef
PING 2a02:bd0:abcd:1::20(2a02:bd0:abcd:1::20) from 2a02:bd0:abcd:4::10 : 56 
data bytes
64 bytes from 2a02:bd0:abcd:1::20: icmp_seq=1 ttl=64 time=3.29 ms

--- 2a02:bd0:abcd:1::20 ping statistics ---
1 packets transmitted, 1 received, 0% packet loss, time 1ms
rtt min/avg/max/mdev = 3.297/3.297/3.297/0.000 ms


west# tcpdump -nvei ipsec0       
tcpdump: listening on ipsec0, link-type EN10MB (Ethernet), capture size 96 
bytes
08:20:12.842694 00:0c:29:3a:e5:22 > 00:0c:29:3a:e5:22, ethertype IPv6 
(0x86dd), length 118: (hlim 64, next-header ICMPv6 (58) payload length: 64) 
2a02:bd0:abcd:4::10 > 2a02:bd0:abcd:1::20: ICMP6, echo request, length 64, seq 
1
08:20:12.845714 00:0c:29:66:94:fd > 00:0c:29:3a:e5:22, ethertype IPv6 
(0x86dd), length 118: (hlim 64, next-header ICMPv6 (58) payload length: 64) 
2a02:bd0:abcd:1::20 > 2a02:bd0:abcd:4::10: ICMP6, echo reply, length 64, seq 1
^C
2 packets captured
2 packets received by filter
0 packets dropped by kernel

The ICMP echo request packet has the wrong destination MAC address: it's the 
MAC address of the local node. It's far less annoying the byte-swap, but I can 
imagine it can be quite annoying when troubleshooting ;-)
I *guess* it has something to do with:
        /*
         * release the dst that was attached, since we have likely
         * changed the actual destination of the packet.
         */

Regards,
Ruben Laban