[Openswan dev] DPD broken in 2.6.23?

[Tuomo Soini]

D. Hugh Redelmeier wrote:

> How would that have ever worked?  It looks very obviously wrong!  Was
> it ever tested?
>
> Why is this the first time anyone noticed?  Is this path rarely use or 
> does it rarely matter?
>
> (I have no idea if I wrote that code so I don't even know if I'm the
> one to answer the questions.  No wait: I can tell by the formatting of
> the two bad lines that I didn't write them.)

I think it was done to fix this issue:

Oct 19 22:48:48 usik pluto[26895]: "foobar" #2: initiating Quick Mode
RSASIG+ENCRYPT+TUNNEL+PFS+UP+IKEv2ALLOW {using isakmp#1 msgid:0a32b87f
proposal=defaults pfsgroup=OAKLEY_GROUP_MODP2048}
Oct 19 22:48:48 usik pluto[26895]: initiate on demand from
87.108.67.176:0 to 87.108.67.162:80 proto=6 state: fos_start because:
acquire
Oct 19 22:48:48 usik pluto[26895]: "foobar" #3: initiating Quick Mode
RSASIG+ENCRYPT+TUNNEL+PFS+UP+IKEv2ALLOW {using isakmp#1 msgid:80ad7a45
proposal=defaults pfsgroup=OAKLEY_GROUP_MODP2048}
Oct 19 22:48:48 usik pluto[26895]: EXPECTATION FAILED at
/builddir/build/BUILD/openswan-2.6.23/programs/pluto/kernel.c:167:
kernel_ops->remove_orphaned_holds != NULL

-- 
Tuomo Soini <tis at foobar.fi>
Foobar Linux services
+358 40 5240030
Foobar Oy <http://foobar.fi/>