[Openswan dev] openswan init script (setup.in) related issues
tis at foobar.fi
Tue Nov 4 16:20:44 EST 2008
-----BEGIN PGP SIGNED MESSAGE-----
Avesh Agarwal wrote:
> I just tested my patch again, and its working fine with "status". I am
> wondering why its behaving differently and not working in your setup. In
> fact "status()" function in my patch does exactly what was being done in
> the original init script file.
Oh. I did partly misread your patch. It might actually work even when
RETVAL is not handled after call for status.
I look again, but I think it's better to handle simple things in place
instead of calling functions without reason. Calling fuction which
simply call one program and run it is no reason for function. At least
it won't do script more maintainable.
I'll look at your patch better tomorrow.
Tuomo Soini <tis at foobar.fi>
Foobar Linux services
+358 40 5240030
Foobar Oy <http://foobar.fi/>
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (GNU/Linux)
-----END PGP SIGNATURE-----
More information about the Dev