[Openswan dev] connections.c
atong at TrustedCS.com
Tue Apr 22 15:37:19 EDT 2008
D. Hugh Redelmeier wrote:
> I don't know what these strings are intended for.
> As you say, alg_esp is not used. Either it should be used or it
> should be eliminated.
I guess this was the question I was hinting at:)
> They are only set if KERNEL_ALG or IKE_ALG are defined. Perhaps the
> definition and all uses of them should be similarly conditional.
> If they remain, they should certainly be cloned in
> unshare_connection_strings. Why did you not use this fix?
In 2.4.x alg_ike wasnt used either (it looks like it is, but it's a
no-op), so I figured those were there for legacy reasons and never got
cleaned up. The relevant info in these strings are already parsed&saved
in a ref counted structure.
More information about the Dev