[Openswan dev] Re: PATCH: fix oops during KLIPS unloading

Paul Wouters paul at xelerance.com
Mon Feb 13 21:22:31 CET 2006


On Mon, 13 Feb 2006, D. Hugh Redelmeier wrote:

> | From: Paul Wouters <paul at xelerance.com>
>
> | The bug item is left open until a testcase has been written for this issue.
>
> The methodology calls for a test BEFORE a fix.  That is the way you
> can tell that the test actually will fail without the fix (i.e. that
> the fix fixes what the test tests).
>
> When you get around to writing the test, be sure to revert this fix so
> that you can test the test.

The fix did see some testing on Iron. So in that sense it is confirmed.
I agree a testcase ideally is written before committing code.

Paul
-- 

"Happiness is never grand"

	--- Mustapha Mond, World Controller (Brave New World)


More information about the Dev mailing list