[Openswan dev] [PATCH] Fix delayed crypto crash

Herbert Xu herbert at gondor.apana.org.au
Fri Sep 30 17:01:53 CEST 2005


On Thu, Sep 29, 2005 at 08:04:18PM +0200, Paul Wouters wrote:
> On Thu, 29 Sep 2005, Herbert Xu wrote:
> 
> >When we suspend a state because the skeyids haven't been calculated yet,
> >the message is freed even though the state still needs it.
> >
> >This patch fixes the typo that causes this.

Unfortunately that still crashes should the negotiation time out for
whatever reason.  The reason is that md->st is NULL which blows up
in delete_state.

This patch should fix that problem.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert at gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-------------- next part --------------
? programs/pluto/_pluto_adns
? programs/pluto/pluto
? programs/pluto/whack
Index: programs/pluto/demux.c
===================================================================
RCS file: /var/cvs/snwb/packages/openswan/programs/pluto/demux.c,v
retrieving revision 1.3
diff -u -r1.3 demux.c
--- programs/pluto/demux.c	29 Sep 2005 06:41:16 -0000	1.3
+++ programs/pluto/demux.c	30 Sep 2005 05:45:55 -0000
@@ -1967,6 +1967,7 @@
 
 	if(st->st_suspended_md) { release_md(st->st_suspended_md); }
 	st->st_suspended_md = md;
+	md->st = st;
 	*mdp = NULL;
 	return;
     }


More information about the Dev mailing list