[Openswan dev] Openswan-2.3.0dr3 to Checkpoint NG AI55 success
mcr at marajade.sandelman.ottawa.on.ca
Fri Nov 26 12:15:14 CET 2004
-----BEGIN PGP SIGNED MESSAGE-----
>>>>> "Karl" == Karl Vogel <karl.vogel at telenet.be> writes:
Karl> Maybe a proper solution would be to accept '@' as last
Karl> character, but emit a big fat warning about a broken
Karl> implementation?! Or would an extra ipsec.conf connection
Karl> option to allow this brokenness be better?
So, if you say user@\0, then you propose that we remove the @
character in that situation?
Each such minor "edit" creates complexity.
To get a patch easily accepted, start by writing a test case for it.
(So, that means that you have to have a way to expect user@ on the
responder as well!)
Make your fix so that things work.
Then, run all of the other pluto test cases. Did you break anything?
] ON HUMILITY: to err is human. To moo, bovine. | firewalls [
] Michael Richardson, Xelerance Corporation, Ottawa, ON |net architect[
] mcr at xelerance.com http://www.sandelman.ottawa.on.ca/mcr/ |device driver[
] panic("Just another Debian GNU/Linux using, kernel hacking, security guy"); [
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2 (GNU/Linux)
Comment: Finger me for keys
-----END PGP SIGNATURE-----
More information about the Dev