[Openswan dev] DPD broken with xauth?

[Ken Bantoft]

All cleaned up in HEAD, I think.

Note that our internal CVS only syncs with anoncvs.openswan.org once an 
hour, so we might say 'fixed in HEAD' because we just commited, but it 
hasn't synced yet.

I've manually pushed the sync now.

Jiva DeVoe wrote:

>Although, wait a sec... No, this still can't work right?
>
>This line:
>
>    int numvidtosend = 1;  /* we always send DPD VID */
>
>
>And this code:
>
>     /* see if we are doing DPD, and if so, note another vid to send */
>     if(st->st_connection->dpd_delay && st->st_connection->dpd_timeout) {
>     numvidtosend++;
>     } 
>
>Are at odds with each other are they not?
>
>This would cause this error:
>
>    if(numvidtosend != 0) {
>    openswan_log("payload alignment problem please check the code in
>main_inI1_outR1 (num=%d)", numvidtosend);
>    }
>
>To be shown, since numvidtosend would be 1 more than needed.
>
>This code is in current cvs.
>
>
>On 12/21/04 2:57 PM, "Jiva DeVoe" <jiva at ixiacom.com> wrote:
>
>  
>
>>Ok, I sit corrected, either I missed the other fix in ipsec_doi.c or it
>>wasn't there earlier, or something... But I see it's there now... My
>>mistake, sorry.
>>
>>
>>
>>On 12/21/04 2:51 PM, "Jiva DeVoe" <jiva at ixiacom.com> wrote:
>>
>>    
>>
>>>The problem is, the latest ipsec_doi.c from CVS HEAD does not work and has
>>>this problem as well.  (This is running on that code)
>>>
>>>
>>>On 12/21/04 2:49 PM, "Paul Wouters" <paul at xelerance.com> wrote:
>>>
>>>      
>>>
>>>>On Tue, 21 Dec 2004, Jiva DeVoe wrote:
>>>>
>>>>        
>>>>
>>>>>Getting the following error when running with xauth and dpd:
>>>>>
>>>>>"Connection0" #1: ASSERTION FAILED at timer.c:103: st->st_dpd_event == NULL
>>>>>
>>>>>Is it broken?
>>>>>          
>>>>>
>>>>It sems to be the result of your patch. Please checkout the latest
>>>>ipsec_doi.c
>>>>from CVS HEAD for a proper fix.
>>>>
>>>>Paul
>>>>        
>>>>
>>>_______________________________________________
>>>Dev mailing list
>>>Dev at openswan.org
>>>http://lists.openswan.org/mailman/listinfo/dev
>>>      
>>>
>
>
>_______________________________________________
>Dev mailing list
>Dev at openswan.org
>http://lists.openswan.org/mailman/listinfo/dev
>  
>