[OpenSWAN dev] patches to pluto

[Michael Richardson]

-----BEGIN PGP SIGNED MESSAGE-----


When doing patches to pluto, can I make the following suggestions as to
style:
	1) please test compile with your -DMYFEATURE off.

	2) packet.[ch] and constants.[ch] should always include the feature,
	   and should not #ifdef MYFEATURE. 

	3) other headers can omit #ifdef MYFEATURE if the types involved
	   are simple (i.e. "int"), or already defined.

	4) all of the tests MUST pass with -DMYFEATURE off.
	   tests should pass with -DMYFEATURE on, and ideally,
	   you have written new tests. Talk to me about this.

In general, more #ifdef's make code harder to read.

Feel free to put:
     /* MYFEATURE START */

around the code in contants.h if you want to aid grep'ing.

]       ON HUMILITY: to err is human. To moo, bovine.           |  firewalls  [
]   Michael Richardson,    Xelerance Corporation, Ottawa, ON    |net architect[
] mcr at xelerance.com      http://www.sandelman.ottawa.on.ca/mcr/ |device driver[
] panic("Just another Debian GNU/Linux using, kernel hacking, security guy"); [
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2 (GNU/Linux)
Comment: Finger me for keys

iQCVAwUBP9Z7kYqHRg3pndX9AQFe6QP/cqVZBYtHEW/KKLT2COCYv2mNnKOSj35B
Rv8yKiIBqn92s7SbCvIhV3d6ThZXKd4rulJc3eIItfEnb5+XOu4aodKGURMwvQTw
sCi03WLZhm/7eZtW60TnL+OP4OesURV9HQoj9q00PIxNk8fc1cu2iLMcjhpi4J/v
f3sUDOENM9I=
=1g1e
-----END PGP SIGNATURE-----