[Openswan dev] ipsec.conf processing: missing include files

[Paul Wouters]

On Tue, 8 Jul 2008, D. Hugh Redelmeier wrote:

> Date: Tue, 8 Jul 2008 11:07:54 -0400 (EDT)
> From: D. Hugh Redelmeier <hugh at mimosa.com>
> To:  <dev at openswan.org>
> Subject: [Openswan dev] ipsec.conf processing: missing include files
> 
> This is with respect to how libipsecconf behaves, not the scripts.
> 
> When an ipsec.conf uses the include directive, and the file mentioned does 
> not exist, the error message is terrible.  It claims to be in the first 
> line of the missing file.
> 
> parser.l looks for include files using the glob(3) library call.  One of 
> the calls uses the flag GLOB_NOMAGIC (a GNU-extension).  This call then 
> succeeds even if there is no match.
> 
> This seems like a mistake.  When would this be the right thing to do?  
> Perhaps if the file's actual name includes glob wildchars.  But by that 
> argument, all glob calls should have that flag.
> 
> I propose getting rid of GLOB_NOMAGIC.
> 
> I'm too lazy to figure out what the scripts do or what the documentation 
> says.

That's fine, as long as processing does not eror with an exit for a missing
includ file (which was the old behaviour that was fixed a few months ago)

So, if with your change, we can still have: include /no/such/file.conf, and
it will just get ignored, then I see no problem.

Paul